Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add note to optimize docs to use prefix when setting env vars #3975

Merged
merged 4 commits into from
Jul 22, 2024
Merged

add note to optimize docs to use prefix when setting env vars #3975

merged 4 commits into from
Jul 22, 2024

Conversation

conceptualshark
Copy link
Contributor

Description

Resolves #3683

Clarify that the CAMUNDA_OPTIMIZE_ prefix is required when converting config properties to env vars in optimize.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@conceptualshark conceptualshark added component:optimize Issues related with Optimize project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Jun 24, 2024
@conceptualshark conceptualshark self-assigned this Jun 24, 2024
@christinaausley
Copy link
Contributor

christinaausley commented Jul 22, 2024 •
edited
Loading

@conceptualshark Are you just waiting on review from @falko here, or do you have additional changes coming? Can always merge, and make any retro changes in another PR if Falko is busy this week.

@conceptualshark
Copy link
Contributor Author

@christinaausley I updated a small error, but can go ahead and merge - I don't imagine they would cause any additional confusion, and feel comfortable updating any changes quickly if they're needed.

@conceptualshark conceptualshark merged commit be6887d into main Jul 22, 2024
7 checks passed
@conceptualshark conceptualshark deleted the optimize-env-vars branch July 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaausley christinaausley christinaausley approved these changes

@falko falko Awaiting requested review from falko

Assignees

@conceptualshark conceptualshark

Labels
component:optimize Issues related with Optimize project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Developer Experience
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undocumented env var prefix CAMUNDA_OPTIMIZE_
2 participants
@conceptualshark @christinaausley